This repository was archived by the owner on Dec 21, 2023. It is now read-only.
Replace bootstrap <button> with identically styled <a> hyperlinks#7
Merged
InfinityGhost merged 1 commit intoOpenTabletDriver:masterfrom Aug 5, 2021
Merged
Conversation
Contributor
Author
|
I haven't actually tested this with my own build since I can't get my Visual Studio instance to see .net5, but it's a trivial change that should be easy to test. I tried making the same change in the browser on the generated html at least though and it did work. EDIT: I'm updating Visual Studio, .net5 should work once it's updated. Testing incoming hopefully. |
Contributor
Author
|
Just got it running on my VS. All the buttons work like normal links and look the same as before. The fade animation still works. It is ready to merge whenever. |
vgf89
changed the title
vgf89
changed the title
InfinityGhost
approved these changes
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the buttons act like regular links, using the same bootstrap style stuff as the bootstrap buttons. The URL can be previewed, middle-clicking with mouse opens in new tab, etc etc.